Issue 7312025: Change wording on incognito NTP to reflect the fact that all incognito windows need to be closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7312025: Change wording on incognito NTP to reflect the fact that all incognito windows need to be closed. (Closed)

Created:
9 years, 5 months ago by Bernhard Bauer

Modified:
9 years, 5 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews, Patrick Nepper, chrome-ui-leads_google.com, Mike West

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Change wording on incognito NTP to reflect the fact that all incognito windows need to be closed for the session to end. BUG=88411 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91705

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike West

Nit: Maybe bold or italicize "all", since that's the point of concern?

9 years, 5 months ago (2011-07-07 13:26:20 UTC) #2

Glen Murphy

LGTM. I don't think it's necessary to italicize all, but your call. On Thu, Jul ...

9 years, 5 months ago (2011-07-07 14:49:36 UTC) #3

Bernhard Bauer

9 years, 5 months ago (2011-07-07 15:17:50 UTC) #4

On 2011/07/07 14:49:36, Glen Murphy wrote:
> LGTM. I don't think it's necessary to italicize all, but your call.

Committed with <strong>.

> On Thu, Jul 7, 2011 at 6:26 AM,  <mailto:mkwst@chromium.org> wrote:
> > Nit: Maybe bold or italicize "all", since that's the point of concern?
> >
> > http://codereview.chromium.org/7312025/
> >

Expand Messages | Collapse Messages