Destroy egl image handles in the end of playback.

content/common/gpu/media/omx_video_decode_accelerator.cc

Index: content/common/gpu/media/omx_video_decode_accelerator.cc
===================================================================
--- content/common/gpu/media/omx_video_decode_accelerator.cc	(revision 91551)
+++ content/common/gpu/media/omx_video_decode_accelerator.cc	(working copy)
@@ -700,6 +700,7 @@
     DCHECK(!*omx_buffer);
     void* egl = texture2eglImage_translator.TranslateToEglImage(
         egl_display_, egl_context_, gles_buffer.texture_id());
+    egl_images_.push_back(egl);
     OMX_ERRORTYPE result = OMX_UseEGLImage(
         component_handle_, omx_buffer, output_port_, &gles_buffer, egl);
     if (result != OMX_ErrorNone) {
@@ -750,6 +751,11 @@
     client_->DismissPictureBuffer(it->first);
   }
   pictures_.clear();
+
+  static Gles2TextureToEglImageTranslator texture2eglImage_translator;
+  for (size_t i = 0; i < egl_images_.size(); ++i) {
+    texture2eglImage_translator.DestroyEglImage(egl_display_, egl_images_[i]);

[Ami GONE FROM CHROMIUM, 2011/07/06 15:52:38]

This is a bit late to delete the image, as the underlying texture might already
be freed through the call to DismissPictureBuffer above.

IMO this should be changed to:
- OmxVideoDecodeAccelerator::OutputPicture gets a new field 
EGLImageKHR egl_image;
- Move the TranslateToEglImage call from AllocateOutputBuffers to
AssignGLESBuffers right before constructing the OutputPicture to be added to
pictures_
- Call DestroyEglImage(it->egl_image) right above the call to
client_->DismissPictureBuffer(it->first) above.

This has the benefits of:
- Keeping the book-keeping data together; all the "views" of a particular
picture are in the same place
- Makes destruction order mirror construction order.

[vhiremath, 2011/07/07 06:00:37]

Done.

+  }
 }
 
 void OmxVideoDecodeAccelerator::OnIndexParamPortDefinitionChanged(int port) {