Destroy egl image handles in the end of playback.

content/common/gpu/media/omx_video_decode_accelerator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/omx_video_decode_accelerator.h"
 
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
 #include "content/common/gpu/gpu_channel.h"
 #include "content/common/gpu/media/gles2_texture_to_egl_image_translator.h"
@@ skipping 682 matching lines @@
   DCHECK(!pictures_.empty());
   gfx::Size decoded_pixel_size(pictures_.begin()->second.gles_buffer.size());
   gfx::Size visible_pixel_size(pictures_.begin()->second.gles_buffer.size());
   for (OutputPictureById::iterator it = pictures_.begin();
        it != pictures_.end(); ++it) {
     media::GLESBuffer& gles_buffer = it->second.gles_buffer;
     OMX_BUFFERHEADERTYPE** omx_buffer = &it->second.omx_buffer_header;
     DCHECK(!*omx_buffer);
     void* egl = texture2eglImage_translator.TranslateToEglImage(
         egl_display_, egl_context_, gles_buffer.texture_id());
+    egl_images_.push_back(egl);
     OMX_ERRORTYPE result = OMX_UseEGLImage(
         component_handle_, omx_buffer, output_port_, &gles_buffer, egl);
     if (result != OMX_ErrorNone) {
       LOG(ERROR) << "OMX_UseEGLImage failed with: " << result;
       return false;
     }
     // Here we set a garbage bitstream buffer id, and then overwrite it before
     // passing to PictureReady.
     int garbage_bitstream_buffer_id = -1;
     (*omx_buffer)->pAppPrivate =
@@ skipping 30 matching lines @@
     delete reinterpret_cast<media::Picture*>(omx_buffer->pAppPrivate);
     result = OMX_FreeBuffer(component_handle_, output_port_, omx_buffer);
     if (result != OMX_ErrorNone) {
       LOG(ERROR) << "OMX_FreeBuffer failed with: " << result;
       StopOnError(VIDEODECODERERROR_INVALIDINPUT);
       return;
     }
     client_->DismissPictureBuffer(it->first);
   }
   pictures_.clear();
+
+  static Gles2TextureToEglImageTranslator texture2eglImage_translator;
+  for (size_t i = 0; i < egl_images_.size(); ++i) {
+    texture2eglImage_translator.DestroyEglImage(egl_display_, egl_images_[i]);

[Ami GONE FROM CHROMIUM, 2011/07/06 15:52:38]

This is a bit late to delete the image, as the underlying texture might already
be freed through the call to DismissPictureBuffer above.

IMO this should be changed to:
- OmxVideoDecodeAccelerator::OutputPicture gets a new field 
EGLImageKHR egl_image;
- Move the TranslateToEglImage call from AllocateOutputBuffers to
AssignGLESBuffers right before constructing the OutputPicture to be added to
pictures_
- Call DestroyEglImage(it->egl_image) right above the call to
client_->DismissPictureBuffer(it->first) above.

This has the benefits of:
- Keeping the book-keeping data together; all the "views" of a particular
picture are in the same place
- Makes destruction order mirror construction order.

[vhiremath, 2011/07/07 06:00:37]

Done.

+  }
 }
 
 void OmxVideoDecodeAccelerator::OnIndexParamPortDefinitionChanged(int port) {
   DCHECK_EQ(port, output_port_);
   DCHECK(!on_port_disable_event_func_);
   on_port_disable_event_func_ =
       &OmxVideoDecodeAccelerator::PortDisabledForSettingsChange;
   ChangePort(OMX_CommandPortDisable, port);
 }
 
@@ skipping 267 matching lines @@
   OMX_ERRORTYPE result = OMX_SendCommand(component_handle_,
                                          cmd, port_index, 0);
   if (result != OMX_ErrorNone) {
     LOG(ERROR) << "SendCommand() failed" << cmd << ":" << result;
     StopOnError(VIDEODECODERERROR_INVALIDINPUT);
     return;
   }
 }
 
 DISABLE_RUNNABLE_METHOD_REFCOUNT(OmxVideoDecodeAccelerator);