Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7311004: Destroy egl image handles in the end of playback. (Closed)

Created:
9 years, 5 months ago by vhiremath
Modified:
9 years, 5 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), nwartikar, ashok, Alka, vjain
Visibility:
Public.

Description

Destroy egl image handles in the end of playback. Clean up a couple of unused variables. BUG=NONE TEST=omx_video_decode_accelerator_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91677

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator.h View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.cc View 1 2 3 4 5 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vhiremath
Ami, We were not destroying egl image handles in the end of playback. Please review. ...
9 years, 5 months ago (2011-07-06 12:58:17 UTC) #1
vhiremath
Tested with omx_video_decode_accelerator_unittest
9 years, 5 months ago (2011-07-06 13:11:20 UTC) #2
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/7311004/diff/1003/content/common/gpu/media/omx_video_decode_accelerator.cc File content/common/gpu/media/omx_video_decode_accelerator.cc (right): http://codereview.chromium.org/7311004/diff/1003/content/common/gpu/media/omx_video_decode_accelerator.cc#newcode757 content/common/gpu/media/omx_video_decode_accelerator.cc:757: texture2eglImage_translator.DestroyEglImage(egl_display_, egl_images_[i]); This is a bit late to delete ...
9 years, 5 months ago (2011-07-06 15:52:38 UTC) #3
vhiremath
http://codereview.chromium.org/7311004/diff/1003/content/common/gpu/media/omx_video_decode_accelerator.cc File content/common/gpu/media/omx_video_decode_accelerator.cc (right): http://codereview.chromium.org/7311004/diff/1003/content/common/gpu/media/omx_video_decode_accelerator.cc#newcode757 content/common/gpu/media/omx_video_decode_accelerator.cc:757: texture2eglImage_translator.DestroyEglImage(egl_display_, egl_images_[i]); On 2011/07/06 15:52:38, Ami Fischman wrote: > ...
9 years, 5 months ago (2011-07-07 06:00:37 UTC) #4
Ami GONE FROM CHROMIUM
LGTM Thanks for doing this! http://codereview.chromium.org/7311004/diff/5004/content/common/gpu/media/omx_video_decode_accelerator.cc File content/common/gpu/media/omx_video_decode_accelerator.cc (right): http://codereview.chromium.org/7311004/diff/5004/content/common/gpu/media/omx_video_decode_accelerator.cc#newcode396 content/common/gpu/media/omx_video_decode_accelerator.cc:396: void* egl_image = texture2eglImage_translator.TranslateToEglImage( ...
9 years, 5 months ago (2011-07-07 06:13:33 UTC) #5
vhiremath
On 2011/07/07 06:13:33, Ami Fischman wrote: > LGTM > Thanks for doing this! > > ...
9 years, 5 months ago (2011-07-07 06:30:10 UTC) #6
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 07:55:24 UTC) #7
Change committed as 91677

Powered by Google App Engine
This is Rietveld 408576698