Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 256059: Add comments setting emacs and vim tab width and expansion variables.... (Closed)

Created:
11 years, 2 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, fbarchard, Alpha Left Google, ben+cc_chromium.org, jam, pam+watch_chromium.org, awong, Paweł Hajdan Jr., kuchhal, darin (slow to review), tim (not reviewing), scherkus (not reviewing)
Visibility:
Public.

Description

Add comments setting emacs and vim tab width and expansion variables. BUG=none TEST=successful builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -3 lines) Patch
M app/app.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M breakpad/breakpad.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/all.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M build/external_code.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M build/features_override.gypi View 1 chunk +8 lines, -1 line 0 comments Download
M build/linux/system.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/temp_gyp/pdfsqueeze.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/util/build_util.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M build/win/system.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/locales/locales.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/installer/installer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/security_tests/security_tests.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome_frame/rename_me_to_supplement.gypi View 1 chunk +7 lines, -1 line 0 comments Download
M chrome_frame/support.gyp View 1 chunk +5 lines, -1 line 0 comments Download
M courgette/courgette.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M gears/gears.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M google_update/google_update.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/breakpad/breakpad.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/build/all.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/build/libs.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/build/nacl.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/command_buffer/command_buffer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/compiler/technique/technique.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/converter/converter.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/core/core.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/documentation/documentation.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/google_update/google_update.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/gpu_plugin/gpu_plugin.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/import/archive.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/import/import.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/installer/installer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/installer/mac/installer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/installer/win/installer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/plugin/idl/idl.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/plugin/plugin.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/samples/samples.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/serializer/serializer.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/statsreport/statsreport.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/tests/selenium/selenium.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/tests/tests.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M o3d/utils/utils.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M rlz/rlz.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M sdch/sdch.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/gmock.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/gtest.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/bsdiff/bsdiff.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/bspatch/bspatch.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/cld/cld.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/codesighs/codesighs.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/expat/expat.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/lzma_sdk/lzma_sdk.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/modp_b64/modp_b64.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/npapi/npapi.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/protobuf2/protobuf.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/tcmalloc/tcmalloc.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/zlib/zlib.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/imagediff/image_diff.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/xdisplaycheck/xdisplaycheck.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M views/views.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
This had patch failures on Mac and Linux trybots due to line ending issue (no ...
11 years, 2 months ago (2009-10-05 21:32:55 UTC) #1
Mark Mentovai
11 years, 2 months ago (2009-10-05 21:37:03 UTC) #2
Rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698