Issue 7307033: Fix a regression where the omnibox would re-enter extension keyword mode after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7307033: Fix a regression where the omnibox would re-enter extension keyword mode after (Closed)

Created:
9 years, 5 months ago by Matt Perry

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, asargent_no_longer_on_chrome

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix a regression where the omnibox would re-enter extension keyword mode after choosing a selection. BUG=88552 TEST=see bug for repro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91780

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -14 lines)			Patch
M	chrome/browser/autocomplete/keyword_provider.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_apitest.cc	View	1 2	1 chunk	+46 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/omnibox/test.html	View	1	1 chunk	+13 lines, -13 lines	0 comments	Download

Total messages: 5 (0 generated)

asargent_no_longer_on_chrome

Code change looks good - but is there a test we can write for this?

9 years, 5 months ago (2011-07-07 17:19:16 UTC) #2

Matt Perry

On 2011/07/07 17:19:16, Antony Sargent wrote: > Code change looks good - but is there ...

9 years, 5 months ago (2011-07-07 21:52:35 UTC) #3

Change committed as 91780