Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 7307033: Fix a regression where the omnibox would re-enter extension keyword mode after (Closed)

Created:
9 years, 5 months ago by Matt Perry
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a regression where the omnibox would re-enter extension keyword mode after choosing a selection. BUG=88552 TEST=see bug for repro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91780

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : final comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -14 lines) Patch
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_omnibox_apitest.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/omnibox/test.html View 1 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
9 years, 5 months ago (2011-07-07 01:19:33 UTC) #1
asargent_no_longer_on_chrome
Code change looks good - but is there a test we can write for this?
9 years, 5 months ago (2011-07-07 17:19:16 UTC) #2
Matt Perry
On 2011/07/07 17:19:16, Antony Sargent wrote: > Code change looks good - but is there ...
9 years, 5 months ago (2011-07-07 21:52:35 UTC) #3
asargent_no_longer_on_chrome
LGTM
9 years, 5 months ago (2011-07-07 22:04:31 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 23:11:44 UTC) #5
Change committed as 91780

Powered by Google App Engine
This is Rietveld 408576698