Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/autocomplete/keyword_provider.cc

Issue 7307033: Fix a regression where the omnibox would re-enter extension keyword mode after (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: final comment Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_omnibox_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/keyword_provider.cc
diff --git a/chrome/browser/autocomplete/keyword_provider.cc b/chrome/browser/autocomplete/keyword_provider.cc
index 693d824c7cafcd8581725be43f5fa9e29ce736fa..abf30e09e1ba0892b8fb7066315d4a711c83e7fa 100644
--- a/chrome/browser/autocomplete/keyword_provider.cc
+++ b/chrome/browser/autocomplete/keyword_provider.cc
@@ -461,8 +461,10 @@ void KeywordProvider::Observe(NotificationType type,
switch (type.value) {
case NotificationType::EXTENSION_OMNIBOX_INPUT_ENTERED:
// Input has been accepted, so we're done with this input session. Ensure
- // we don't send the OnInputCancelled event.
+ // we don't send the OnInputCancelled event, or handle any more stray
+ // suggestions_ready events.
current_keyword_extension_id_.clear();
+ current_input_id_ = 0;
return;
case NotificationType::EXTENSION_OMNIBOX_DEFAULT_SUGGESTION_CHANGED: {
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_omnibox_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698