Issue 7307016: Add a test to verify that the data in gtkimcontextsimpleseqs.h is correctly ordered

Issue 7307016: Add a test to verify that the data in gtkimcontextsimpleseqs.h is correctly ordered (Closed)

Created:
9 years, 5 months ago by hashimoto

Modified:
9 years, 5 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add a test to verify that the data in gtkimcontextsimpleseqs.h is correctly ordered BUG=chromium-os:17307 TEST=views_unittests success Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91675

Patch Set 2 : Fixed the order of includes #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	M	views/ime/character_composer_unittest.cc	View	1	2 chunks	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

LGTM with two requests below. Thanks for adding the test. http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_unittest.cc File views/ime/character_composer_unittest.cc (right): http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_unittest.cc#newcode8 ...

9 years, 5 months ago (2011-07-07 06:54:32 UTC) #2

hashimoto

9 years, 5 months ago (2011-07-07 07:24:09 UTC) #3

http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_un...
File views/ime/character_composer_unittest.cc (right):

http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_un...
views/ime/character_composer_unittest.cc:8: #include
"ui/base/gtk/gtk_integers.h"
On 2011/07/07 06:54:32, Yusuke Sato wrote:
> alphabetical order.

Fixed

http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_un...
views/ime/character_composer_unittest.cc:153: // This file is included here
intentionally, instead of the top of the file,
On 2011/07/07 06:54:32, Yusuke Sato wrote:
> then, can't we fix the generator script? if you agree, please file a bug.

Filed http://crosbug.com/17328

http://codereview.chromium.org/7307016/diff/1/views/ime/character_composer_un...
views/ime/character_composer_unittest.cc:157: const int index_size = 26;
On 2011/07/07 06:54:32, Yusuke Sato wrote:
> wondering why these constants are not in the generated header.

Also filed in http://crosbug.com/17328

Expand Messages | Collapse Messages