Add a test to verify that the data in gtkimcontextsimpleseqs.h is correctly ordered

views/ime/character_composer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/ime/character_composer.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/gtk/gtk_integers.h"

[Yusuke Sato, 2011/07/07 06:54:32]

alphabetical order.

[hashimoto, 2011/07/07 07:24:09]

Fixed

 #include "third_party/gtk+/gdk/gdkkeysyms.h"
 
 namespace views {
 
 namespace {
 
 // Expects key is not filtered and no character is composed
 void ExpectKeyNotFiltered(CharacterComposer* character_composer, uint key) {
   EXPECT_FALSE(character_composer->FilterKeyPress(key));
   EXPECT_TRUE(character_composer->GetComposedCharacter().empty());
@@ skipping 121 matching lines @@
 TEST(CharacterComposerTest, CompositionStateIsClearedAfterReset) {
   CharacterComposer character_composer;
   // Even though sequence ['dead acute', 'a'] will compose 'a with acute',
   // no character is composed here because of reset.
   ExpectKeyFiltered(&character_composer, GDK_KEY_dead_acute);
   character_composer.Reset();
   EXPECT_FALSE(character_composer.FilterKeyPress(GDK_KEY_a));
   EXPECT_TRUE(character_composer.GetComposedCharacter().empty());
 }
 
+// ComposeCheckerWithCompactTable in character_composer.cc is depending on the
+// assumption that the data in gtkimcontextsimpleseqs.h is correctly ordered.
+TEST(CharacterComposerTest, MainTableIsCorrectlyOrdered) {
+  // This file is included here intentionally, instead of the top of the file,

[Yusuke Sato, 2011/07/07 06:54:32]

then, can't we fix the generator script? if you agree, please file a bug.

[hashimoto, 2011/07/07 07:24:09]

Filed http://crosbug.com/17328

+  // because including this file at the top of the file will define a
+  // global constant and contaminate the global namespace.
+#include "third_party/gtk+/gtk/gtkimcontextsimpleseqs.h"
+  const int index_size = 26;

[Yusuke Sato, 2011/07/07 06:54:32]

wondering why these constants are not in the generated header.

[hashimoto, 2011/07/07 07:24:09]

Also filed in http://crosbug.com/17328

+  const int index_stride = 6;
+
+  // Verify that the index is correctly ordered
+  for (int i = 1; i < index_size; ++i) {
+    const int index_key_prev = gtk_compose_seqs_compact[(i - 1)*index_stride];
+    const int index_key = gtk_compose_seqs_compact[i*index_stride];
+    EXPECT_TRUE(index_key > index_key_prev);
+  }
+
+  // Verify that the sequenes are correctly ordered
+  struct {
+    int operator()(const uint16* l, const uint16* r, int length) const{
+      for (int i = 0; i < length; ++i) {
+        if (l[i] > r[i])
+          return 1;
+        if (l[i] < r[i])
+          return -1;
+      }
+      return 0;
+    }
+  } compare_sequence;
+
+  for (int i = 0; i < index_size; ++i) {
+    for (int length = 1; length < index_stride - 1; ++length) {
+      const int index_begin = gtk_compose_seqs_compact[i*index_stride + length];
+      const int index_end =
+          gtk_compose_seqs_compact[i*index_stride + length + 1];
+      const int stride = length + 1;
+      for (int index = index_begin + stride; index < index_end;
+           index += stride) {
+        const uint16* sequence = &gtk_compose_seqs_compact[index];
+        const uint16* sequence_prev = sequence - stride;
+        EXPECT_EQ(compare_sequence(sequence, sequence_prev, length), 1);
+      }
+    }
+  }
+}
+
 }  // namespace views