Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: content/common/process_watcher_unittest.cc

Issue 7304008: Ensure tests check the return of SpawnChild() when they may wait without timeouts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mac compile fixes Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/shared_memory_unittest.cc ('k') | content/common/sandbox_mac_diraccess_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/process_watcher_unittest.cc
diff --git a/content/common/process_watcher_unittest.cc b/content/common/process_watcher_unittest.cc
index 260075bf653fcf5c42f38681b7ff36a975180316..f1890ad385674f1384aa7c8d543b6c6fa417dd3d 100644
--- a/content/common/process_watcher_unittest.cc
+++ b/content/common/process_watcher_unittest.cc
@@ -31,6 +31,7 @@ bool IsProcessDead(base::ProcessHandle child) {
TEST_F(ProcessWatcherTest, DelayedTermination) {
base::ProcessHandle child_process =
SpawnChild("process_watcher_test_never_die", false);
+ ASSERT_TRUE(child_process);
ProcessWatcher::EnsureProcessTerminated(child_process);
base::WaitForSingleProcess(child_process, 5000);
@@ -49,6 +50,7 @@ MULTIPROCESS_TEST_MAIN(process_watcher_test_never_die) {
TEST_F(ProcessWatcherTest, ImmediateTermination) {
base::ProcessHandle child_process =
SpawnChild("process_watcher_test_die_immediately", false);
+ ASSERT_TRUE(child_process);
// Give it time to die.
sleep(2);
ProcessWatcher::EnsureProcessTerminated(child_process);
« no previous file with comments | « base/shared_memory_unittest.cc ('k') | content/common/sandbox_mac_diraccess_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698