Ensure tests check the return of SpawnChild() when they may wait without timeouts

content/common/process_watcher_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/process_watcher.h"
 
 #if defined(OS_POSIX)
 #include <sys/wait.h>
 
 #include "base/eintr_wrapper.h"
@@ skipping 13 matching lines @@
   // we'll get a nice value for errno which we can test for.
   const pid_t result = HANDLE_EINTR(waitpid(child, NULL, WNOHANG));
   return result == -1 && errno == ECHILD;
 }
 
 }  // namespace
 
 TEST_F(ProcessWatcherTest, DelayedTermination) {
   base::ProcessHandle child_process =
       SpawnChild("process_watcher_test_never_die", false);
+  ASSERT_TRUE(child_process);
   ProcessWatcher::EnsureProcessTerminated(child_process);
   base::WaitForSingleProcess(child_process, 5000);
 
   // Check that process was really killed.
   EXPECT_TRUE(IsProcessDead(child_process));
   base::CloseProcessHandle(child_process);
 }
 
 MULTIPROCESS_TEST_MAIN(process_watcher_test_never_die) {
   while (1) {
     sleep(500);
   }
   return 0;
 }
 
 TEST_F(ProcessWatcherTest, ImmediateTermination) {
   base::ProcessHandle child_process =
       SpawnChild("process_watcher_test_die_immediately", false);
+  ASSERT_TRUE(child_process);
   // Give it time to die.
   sleep(2);
   ProcessWatcher::EnsureProcessTerminated(child_process);
 
   // Check that process was really killed.
   EXPECT_TRUE(IsProcessDead(child_process));
   base::CloseProcessHandle(child_process);
 }
 
 MULTIPROCESS_TEST_MAIN(process_watcher_test_die_immediately) {
   return 0;
 }
 
 #endif  // OS_POSIX