Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 73021: Review Request: fix 5729 - RTL: TabStrip context menu should be positioned properly, If window is no (Closed)

Created:
11 years, 8 months ago by xji
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL fixes issue 5729 - RTL: TabStrip context menu should be positioned properly, If window is not maxmized. (http://crbug.com/5729). The fix is to popup tabstrip context menu from the left of the click in RTL UI. Without the fix, tabstrip context menu always popup from the right of the click. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/views/tabs/tab.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
xji
11 years, 8 months ago (2009-04-13 22:56:40 UTC) #1
jungshik at Google
On 2009/04/13 22:56:40, xji wrote: > Do we have an agreement on the correct behavior?
11 years, 8 months ago (2009-04-14 19:56:13 UTC) #2
idana
11 years, 8 months ago (2009-04-16 21:35:39 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698