chrome/browser/views/tabs/tab.cc - Issue 73021: Review Request: fix 5729 - RTL: TabStrip context menu should be positioned properly, If window is no

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/tabs/tab.cc

Issue 73021: Review Request: fix 5729 - RTL: TabStrip context menu should be positioned properly, If window is no (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/views/tabs/tab.cc

===================================================================

--- chrome/browser/views/tabs/tab.cc (revision 13284)

+++ chrome/browser/views/tabs/tab.cc (working copy)

@@ -50,8 +50,11 @@

}

void RunMenuAt(int x, int y) {

+ views::MenuItemView::AnchorPosition anchor =

+ (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) ?

+ views::MenuItemView::TOPRIGHT : views::MenuItemView::TOPLEFT;

menu_->RunMenuAt(tab_->GetWidget()->GetNativeView(), gfx::Rect(x, y, 0, 0),

- views::MenuItemView::TOPLEFT, true);

+ anchor, true);

if (tab_)

tab_->ContextMenuClosed();

delete this;

« no previous file with comments | « no previous file | no next file » | no next file with comments »