chrome/renderer/about_handler.cc - Issue 7301003: Make AboutCrash handler crash directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/about_handler.cc

Issue 7301003: Make AboutCrash handler crash directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Oops, and volatile to prevent optimizing undefined behavior. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/about_handler.cc

diff --git a/chrome/renderer/about_handler.cc b/chrome/renderer/about_handler.cc

index de4b57aec325cee746287023d30194ab38c5bc45..c8e16042795cde6387db9b2f38292f4242a5929e 100644

--- a/chrome/renderer/about_handler.cc

+++ b/chrome/renderer/about_handler.cc

@@ -43,7 +43,14 @@ bool AboutHandler::MaybeHandle(const GURL& url) {

// static

void AboutHandler::AboutCrash() {

- CHECK(false);

+ // NOTE(shess): Crash directly rather than using NOTREACHED() so

+ // that the signature is easier to triage in crash reports.

+ volatile int* zero = NULL;

+ *zero = 0;

+ // Just in case the compiler decides the above is undefined and

+ // optimizes it away.

Nico 2011/07/03 19:34:37 I don't think that can happen with a volatile poin

+ NOTREACHED();

}

// static

« no previous file with comments | « no previous file | no next file » | no next file with comments »