Make AboutCrash handler crash directly.

chrome/renderer/about_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/about_handler.h"
 
 #include "base/logging.h"
 #include "base/process_util.h"
 #include "base/threading/platform_thread.h"
 #include "chrome/common/about_handler.h"
@@ skipping 25 matching lines @@
       return true;  // theoretically :]
     }
     url_handler++;
     about_urls_handler_index++;
   }
   return false;
 }
 
 // static
 void AboutHandler::AboutCrash() {
-  CHECK(false);
+  // NOTE(shess): Crash directly rather than using NOTREACHED() so
+  // that the signature is easier to triage in crash reports.
+  volatile int* zero = NULL;
+  *zero = 0;
+
+  // Just in case the compiler decides the above is undefined and
+  // optimizes it away.

[Nico, 2011/07/03 19:34:37]

I don't think that can happen with a volatile pointer, 'cause volatile means
"contents can change in a volatile manner (e.g. when the pointer really reads
from a hardware device)"?

+  NOTREACHED();
 }
 
 // static
 void AboutHandler::AboutKill() {
   base::KillProcess(base::GetCurrentProcessHandle(), 1, false);
 }
 
 // static
 void AboutHandler::AboutHang() {
   for (;;) {
     base::PlatformThread::Sleep(1000);
   }
 }
 
 // static
 void AboutHandler::AboutShortHang() {
   base::PlatformThread::Sleep(20000);
 }
 
 // static
 size_t AboutHandler::AboutURLHandlerSize() {
   return arraysize(about_urls_handlers);
 }