Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/renderer/about_handler.cc

Issue 7301003: Make AboutCrash handler crash directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/about_handler.cc
diff --git a/chrome/renderer/about_handler.cc b/chrome/renderer/about_handler.cc
index de4b57aec325cee746287023d30194ab38c5bc45..ecfeeba9ab7e9d489d855fb2766967e76a105fc7 100644
--- a/chrome/renderer/about_handler.cc
+++ b/chrome/renderer/about_handler.cc
@@ -4,7 +4,6 @@
#include "chrome/renderer/about_handler.h"
-#include "base/logging.h"
#include "base/process_util.h"
#include "base/threading/platform_thread.h"
#include "chrome/common/about_handler.h"
@@ -43,7 +42,10 @@ bool AboutHandler::MaybeHandle(const GURL& url) {
// static
void AboutHandler::AboutCrash() {
- CHECK(false);
+ // NOTE(shess): Crash directly rather than using NOTREACHED() so
+ // that the signature is easier to triage in crash reports.
+ int* zero = NULL;
+ *zero = 0;
Scott Hess - ex-Googler 2011/07/01 19:59:01 In an email thread, msw said:
}
// static
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698