Make AboutCrash handler crash directly.

chrome/renderer/about_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/about_handler.h"
 
-#include "base/logging.h"
 #include "base/process_util.h"
 #include "base/threading/platform_thread.h"
 #include "chrome/common/about_handler.h"
 #include "content/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 
 typedef void (*AboutHandlerFuncPtr)();
 
 // This needs to match up with chrome_about_handler::about_urls in
 // chrome/common/about_handler.cc.
@@ skipping 18 matching lines @@
       return true;  // theoretically :]
     }
     url_handler++;
     about_urls_handler_index++;
   }
   return false;
 }
 
 // static
 void AboutHandler::AboutCrash() {
-  CHECK(false);
+  // NOTE(shess): Crash directly rather than using NOTREACHED() so
+  // that the signature is easier to triage in crash reports.
+  int* zero = NULL;
+  *zero = 0;

[Scott Hess - ex-Googler, 2011/07/01 19:59:01]

In an email thread, msw said:
Would the use of volatile be to prevent the compiler from realizing that this is
undefined behavior?

Regardless, it seems reasonable to add a NOTREACHED() after this, just in case.

 }
 
 // static
 void AboutHandler::AboutKill() {
   base::KillProcess(base::GetCurrentProcessHandle(), 1, false);
 }
 
 // static
 void AboutHandler::AboutHang() {
   for (;;) {
     base::PlatformThread::Sleep(1000);
   }
 }
 
 // static
 void AboutHandler::AboutShortHang() {
   base::PlatformThread::Sleep(20000);
 }
 
 // static
 size_t AboutHandler::AboutURLHandlerSize() {
   return arraysize(about_urls_handlers);
 }