Issue 7300018: Revert 91390 (build breakage) - Convert ViewMsg_NetworkStateChanged from routed -> control

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7300018: Revert 91390 (build breakage) - Convert ViewMsg_NetworkStateChanged from routed -> control (Closed)

Created:
9 years, 5 months ago by adamk

Modified:
9 years, 5 months ago

Reviewers:
adamk

CC:
chromium-reviews, Avi (use Gerrit), jam, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 91390 (build breakage) - Convert ViewMsg_NetworkStateChanged from routed -> control allowing it to be sent from BrowserRenderProcessHost::OnProcessLaunched and minimizing the number of required IPCs (since the online state is a per-WebKit singleton). In doing so, I've disentangled online state management from TabContents: it now resides off by itself in BrowserOnlineStateObserver, a tiny class owned by BrowserProcessImpl. BUG=7469, 86538 TEST=begin with network disconnected, open new tab, load test page attached to 7469, then re-connect network Review URL: http://codereview.chromium.org/7259004 TBR=eroman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91392

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -82 lines)			Patch
M	chrome/browser/browser_process_impl.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/speech/speech_input_bubble.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_drag_dest_gtk.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/shell_dialogs.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/browser/net/browser_online_state_observer.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	content/browser/net/browser_online_state_observer.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	content/browser/renderer_host/browser_render_process_host.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	5 chunks	+9 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	4 chunks	+16 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/render_thread.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_thread.cc	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	content/renderer/render_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view.cc	View	4 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages