Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 7259004: Convert ViewMsg_NetworkStateChanged from routed -> control, allowing (Closed)

Created:
9 years, 6 months ago by adamk
Modified:
9 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Convert ViewMsg_NetworkStateChanged from routed -> control allowing it to be sent from BrowserRenderProcessHost::OnProcessLaunched and minimizing the number of required IPCs (since the online state is a per-WebKit singleton). In doing so, I've disentangled online state management from TabContents: it now resides off by itself in BrowserOnlineStateObserver, a tiny class owned by BrowserProcessImpl. BUG=7469, 86538 TEST=begin with network disconnected, open new tab, load test page attached to 7469, then re-connect network Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91390

Patch Set 1 #

Patch Set 2 : Create a very simple observer, use it in BrowserProcess #

Total comments: 2

Patch Set 3 : Fixed reference to WebKit class #

Patch Set 4 : Fix linux build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -35 lines) Patch
M chrome/browser/browser_process_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_dest_gtk.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/shell_dialogs.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/net/browser_online_state_observer.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A content/browser/net/browser_online_state_observer.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 5 chunks +2 lines, -9 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 4 chunks +0 lines, -16 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view.cc View 1 2 4 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
9 years, 5 months ago (2011-07-01 18:13:15 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/7259004/diff/1001/content/renderer/render_thread.cc File content/renderer/render_thread.cc (right): http://codereview.chromium.org/7259004/diff/1001/content/renderer/render_thread.cc#newcode676 content/renderer/render_thread.cc:676: WebKit::WebNetworkStateNotifier::setOnLine(online); nit: convention is to add a using ...
9 years, 5 months ago (2011-07-01 18:19:15 UTC) #2
adamk
9 years, 5 months ago (2011-07-01 18:48:06 UTC) #3
http://codereview.chromium.org/7259004/diff/1001/content/renderer/render_thre...
File content/renderer/render_thread.cc (right):

http://codereview.chromium.org/7259004/diff/1001/content/renderer/render_thre...
content/renderer/render_thread.cc:676:
WebKit::WebNetworkStateNotifier::setOnLine(online);
On 2011/07/01 18:19:15, darin wrote:
> nit: convention is to add a using directive at the top of the file to import
> WebNetworkStateNotifier.  then, just call it directly without the WebKit::
> prefix.

Done.

Powered by Google App Engine
This is Rietveld 408576698