Issue 730001: Change BitVector class to be a zone object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 730001: Change BitVector class to be a zone object. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Change BitVector class to be a zone object. Change the BitVector utility class to allow allocation via 'new' in the Zone. Change the backing store to be always zone-allocated. Committed: http://code.google.com/p/v8/source/detail?r=4071

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
	M	src/data-flow.h	View		3 chunks	+27 lines, -22 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years, 9 months ago (2010-03-09 16:52:30 UTC) #2

LGTM.

http://codereview.chromium.org/730001/diff/1/2
File src/data-flow.h (right):

http://codereview.chromium.org/730001/diff/1/2#newcode73
src/data-flow.h:73: bool Contains(int i) {
Should Contains be const too?

Expand Messages | Collapse Messages