Change BitVector class to be a zone object.

src/data-flow.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 14 matching lines @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #ifndef V8_DATAFLOW_H_
 #define V8_DATAFLOW_H_
 
 #include "v8.h"
 
 #include "ast.h"
 #include "compiler.h"
+#include "zone-inl.h"
 
 namespace v8 {
 namespace internal {
 
-class BitVector BASE_EMBEDDED {
+class BitVector: public ZoneObject {
  public:
   explicit BitVector(int length)
-      : length_(length), bits_(Vector<uint32_t>::New(1 + length / 32)) {
+      : length_(length),
+        data_length_(SizeFor(length)),
+        data_(Zone::NewArray<uint32_t>(data_length_)) {
     ASSERT(length > 0);
-    for (int i = 0; i < bits_.length(); i++) {
-      bits_[i] = 0;
-    }
+    Clear();
   }
 
   BitVector(const BitVector& other)
       : length_(other.length()),
-        bits_(Vector<uint32_t>::New(1 + other.length() / 32)) {
+        data_length_(SizeFor(length_)),
+        data_(Zone::NewArray<uint32_t>(data_length_)) {
     CopyFrom(other);
   }
 
-  ~BitVector() { bits_.Dispose(); }
+  static int SizeFor(int length) {
+    return 1 + ((length - 1) / 32);
+  }
 
   BitVector& operator=(const BitVector& rhs) {
     if (this != &rhs) CopyFrom(rhs);
     return *this;
   }
 
   void CopyFrom(const BitVector& other) {
     ASSERT(other.length() == length());
-    for (int i = 0; i < bits_.length(); i++) {
-      bits_[i] = other.bits_[i];
+    for (int i = 0; i < data_length_; i++) {
+      data_[i] = other.data_[i];
     }
   }
 
   bool Contains(int i) {

[fschneider, 2010/03/09 16:52:30]

Should Contains be const too?

     ASSERT(i >= 0 && i < length());
-    uint32_t block = bits_[i / 32];
+    uint32_t block = data_[i / 32];
     return (block & (1U << (i % 32))) != 0;
   }
 
   void Add(int i) {
     ASSERT(i >= 0 && i < length());
-    bits_[i / 32] |= (1U << (i % 32));
+    data_[i / 32] |= (1U << (i % 32));
   }
 
   void Remove(int i) {
     ASSERT(i >= 0 && i < length());
-    bits_[i / 32] &= ~(1U << (i % 32));
+    data_[i / 32] &= ~(1U << (i % 32));
   }
 
   void Union(const BitVector& other) {
     ASSERT(other.length() == length());
-    for (int i = 0; i < bits_.length(); i++) {
-      bits_[i] |= other.bits_[i];
+    for (int i = 0; i < data_length_; i++) {
+      data_[i] |= other.data_[i];
     }
   }
 
   void Intersect(const BitVector& other) {
     ASSERT(other.length() == length());
-    for (int i = 0; i < bits_.length(); i++) {
-      bits_[i] &= other.bits_[i];
+    for (int i = 0; i < data_length_; i++) {
+      data_[i] &= other.data_[i];
     }
   }
 
   void Clear() {
-    for (int i = 0; i < bits_.length(); i++) {
-      bits_[i] = 0;
+    for (int i = 0; i < data_length_; i++) {
+      data_[i] = 0;
     }
   }
 
-  bool IsEmpty() {
-    for (int i = 0; i < bits_.length(); i++) {
-      if (bits_[i] != 0) return false;
+  bool IsEmpty() const {
+    for (int i = 0; i < data_length_; i++) {
+      if (data_[i] != 0) return false;
     }
     return true;
   }
 
   int length() const { return length_; }
 
  private:
   int length_;
-  Vector<uint32_t> bits_;
+  int data_length_;
+  uint32_t* data_;
 };
 
 
 // Forward declarations of Node types.
 class Node;
 class BranchNode;
 class JoinNode;
 
 // Flow graphs have a single entry and single exit.  The empty flowgraph is
 // represented by both entry and exit being NULL.
@@ skipping 367 matching lines @@
   VarUseMap live_vars_;
 
   DISALLOW_COPY_AND_ASSIGN(LivenessAnalyzer);
 };
 
 
 } }  // namespace v8::internal
 
 
 #endif  // V8_DATAFLOW_H_