Issue 7290030: Fix heapchecker failure due to not deleting AVStream*[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7290030: Fix heapchecker failure due to not deleting AVStream*[]. (Closed)

Created:
9 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 5 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, ilja

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Fix heapchecker failure due to not deleting AVStream*[]. Refactored ChunkDemuxerTest to include a ShutdownDemuxer() that cleans up memory. BUG=none TEST=heapcheck passes for media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91267

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -33 lines)			Patch
	M	media/filters/chunk_demuxer_unittest.cc	View		5 chunks	+39 lines, -33 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/07/01 03:53:46, scherkus wrote:

LGTM

Expand Messages | Collapse Messages