Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: media/filters/chunk_demuxer_unittest.cc

Issue 7290030: Fix heapchecker failure due to not deleting AVStream*[]. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer_unittest.cc
diff --git a/media/filters/chunk_demuxer_unittest.cc b/media/filters/chunk_demuxer_unittest.cc
index 210c384a859a396d5c5c27e3a79e569b92678a00..83795e5efdf7d87d079a9664b6d12417e5ba63cd 100644
--- a/media/filters/chunk_demuxer_unittest.cc
+++ b/media/filters/chunk_demuxer_unittest.cc
@@ -57,13 +57,7 @@ class ChunkDemuxerTest : public testing::Test{
}
virtual ~ChunkDemuxerTest() {
- if (demuxer_.get())
- demuxer_->Shutdown();
- if (format_context_.streams) {
- delete[] format_context_.streams;
- format_context_.streams = NULL;
- format_context_.nb_streams = 0;
- }
+ ShutdownDemuxer();
}
void ReadFile(const std::string& name, scoped_array<uint8>* buffer,
@@ -140,31 +134,7 @@ class ChunkDemuxerTest : public testing::Test{
}
}
- void SetupAVFormatContext(bool has_audio, bool has_video) {
- int i = 0;
- format_context_.streams = new AVStream *[MAX_CODECS_INDEX];
- if (has_audio) {
- format_context_.streams[i] = &streams_[i];
- streams_[i].codec = &codecs_[AUDIO];
- streams_[i].duration = 100;
- streams_[i].time_base.den = base::Time::kMicrosecondsPerSecond;
- streams_[i].time_base.num = 1;
- i++;
- }
-
- if (has_video) {
- format_context_.streams[i] = &streams_[i];
- streams_[i].codec = &codecs_[VIDEO];
- streams_[i].duration = 100;
- streams_[i].time_base.den = base::Time::kMicrosecondsPerSecond;
- streams_[i].time_base.num = 1;
- i++;
- }
-
- format_context_.nb_streams = i;
- }
-
-void InitDemuxer(bool has_audio, bool has_video) {
+ void InitDemuxer(bool has_audio, bool has_video) {
EXPECT_CALL(mock_ffmpeg_, AVOpenInputFile(_, _, NULL, 0, NULL))
.WillOnce(DoAll(SetArgumentPointee<0>(&format_context_),
Return(0)));
@@ -187,6 +157,18 @@ void InitDemuxer(bool has_audio, bool has_video) {
has_audio || has_video);
}
+ void ShutdownDemuxer() {
+ if (demuxer_) {
+ demuxer_->Shutdown();
+ }
+
+ if (format_context_.streams) {
+ delete[] format_context_.streams;
+ format_context_.streams = NULL;
+ format_context_.nb_streams = 0;
+ }
+ }
+
void AddSimpleBlock(ClusterBuilder* cb, int track_num, int64 timecode) {
uint8 data[] = { 0x00 };
cb->AddSimpleBlock(track_num, timecode, 0, data, sizeof(data));
@@ -203,6 +185,30 @@ void InitDemuxer(bool has_audio, bool has_video) {
scoped_refptr<ChunkDemuxer> demuxer_;
private:
+ void SetupAVFormatContext(bool has_audio, bool has_video) {
+ int i = 0;
+ format_context_.streams = new AVStream*[MAX_CODECS_INDEX];
+ if (has_audio) {
+ format_context_.streams[i] = &streams_[i];
+ streams_[i].codec = &codecs_[AUDIO];
+ streams_[i].duration = 100;
+ streams_[i].time_base.den = base::Time::kMicrosecondsPerSecond;
+ streams_[i].time_base.num = 1;
+ i++;
+ }
+
+ if (has_video) {
+ format_context_.streams[i] = &streams_[i];
+ streams_[i].codec = &codecs_[VIDEO];
+ streams_[i].duration = 100;
+ streams_[i].time_base.den = base::Time::kMicrosecondsPerSecond;
+ streams_[i].time_base.num = 1;
+ i++;
+ }
+
+ format_context_.nb_streams = i;
+ }
+
DISALLOW_COPY_AND_ASSIGN(ChunkDemuxerTest);
};
@@ -218,7 +224,7 @@ TEST_F(ChunkDemuxerTest, TestInit) {
has_audio);
EXPECT_EQ(demuxer_->GetStream(DemuxerStream::VIDEO).get() != NULL,
has_video);
- demuxer_->Shutdown();
+ ShutdownDemuxer();
demuxer_ = NULL;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698