Issue 7289011: Fix a bug in Object.defineProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7289011: Fix a bug in Object.defineProperty. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 5 months ago

Reviewers:
Karl Klose, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix a bug in Object.defineProperty. There was a bug in Object.defineProperty when used to add an indexed property to an arguments object. When converting the elements backing store to dictionary mode, the parameter map in front of the backing store does not change. R=ager@chromium.org,karlklose@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8481

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -6 lines)			Patch
M	src/handles.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -2 lines	2 comments	Download
A	test/mjsunit/regress/regress-1513.js	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM with one more place to fix. http://codereview.chromium.org/7289011/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7289011/diff/1/src/runtime.cc#newcode3984 src/runtime.cc:3984: Handle<NumberDictionary> dictionary(js_object->element_dictionary()); ...

9 years, 5 months ago (2011-06-30 11:08:41 UTC) #2

Kevin Millikin (Chromium)

9 years, 5 months ago (2011-06-30 11:09:25 UTC) #3

http://codereview.chromium.org/7289011/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7289011/diff/1/src/runtime.cc#newcode3984
src/runtime.cc:3984: Handle<NumberDictionary>
dictionary(js_object->element_dictionary());
On 2011/06/30 11:08:41, Karl Klose wrote:
> Please change this call too.

Good eye!

Expand Messages | Collapse Messages