src/runtime.cc - Issue 7289011: Fix a bug in Object.defineProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 7289011: Fix a bug in Object.defineProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index a6c238c23a21a853af476346a6f79e9c45298aae..65f24900d58e84c188cb74c19d29021340b69adf 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3918,8 +3918,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_DefineOrRedefineDataProperty) {

if (proto->IsNull()) return *obj_value;

js_object = Handle<JSObject>::cast(proto);

}

- NormalizeElements(js_object);

- Handle<NumberDictionary> dictionary(js_object->element_dictionary());

+ Handle<NumberDictionary> dictionary = NormalizeElements(js_object);

// Make sure that we never go back to fast case.

dictionary->set_requires_slow_elements();

PropertyDetails details = PropertyDetails(attr, NORMAL);

« no previous file with comments | « src/handles.cc ('k') | test/mjsunit/regress/regress-1513.js » ('j') | no next file with comments »