Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 7289010: exposing some methods from objects.h (alternative to counters) (Closed)

Created:
9 years, 5 months ago by Yang
Modified:
9 years, 5 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

exposing a few boolean queries from objects.h TEST=start with ./d8 --allow-natives-syntax and try %ObjectHasFastElements({}) Committed: http://code.google.com/p/v8/source/detail?r=8514

Patch Set 1 #

Total comments: 3

Patch Set 2 : changes requested by danno implemented #

Patch Set 3 : added test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -1 line) Patch
M src/runtime.h View 1 2 1 chunk +17 lines, -1 line 0 comments Download
M src/runtime.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A test/mjsunit/element-kind.js View 1 2 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yang
I cooked up something to expose danno's requested JSObject methods in --allow-natives-syntax mode, as alternative ...
9 years, 5 months ago (2011-06-30 08:54:49 UTC) #1
danno
LGTM with comments. http://codereview.chromium.org/7289010/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7289010/diff/1/src/runtime.cc#newcode12478 src/runtime.cc:12478: On 2011/06/30 08:54:49, yangguo wrote: > ...
9 years, 5 months ago (2011-06-30 17:24:04 UTC) #2
Yang
Implemented danno's suggestions. Just need another quick look.
9 years, 5 months ago (2011-07-01 08:23:41 UTC) #3
Yang
Implemented danno's suggestions. Just need another quick look.
9 years, 5 months ago (2011-07-01 08:23:41 UTC) #4
Jakob Kummerow
How about adding a test? ;-)
9 years, 5 months ago (2011-07-01 08:29:39 UTC) #5
Yang
On 2011/07/01 08:29:39, jkummerow wrote: > How about adding a test? ;-) I added the ...
9 years, 5 months ago (2011-07-01 11:27:05 UTC) #6
Jakob Kummerow
9 years, 5 months ago (2011-07-01 11:37:32 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698