exposing some methods from objects.h (alternative to counters)

src/runtime.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 12457 matching lines @@
   LOGGER->LogRuntime(chars, elms);
   return isolate->heap()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(MaybeObject*, Runtime_IS_VAR) {
   UNREACHABLE();  // implemented as macro in the parser
   return NULL;
 }
 
 

[Yang, 2011/06/30 08:54:49]

I hope adding yet another macro is alright. Saves a lot of repetitive code.

[danno, 2011/06/30 17:24:04]

The macro is OK.

I would prefer to make this specific to the elements type for now.
Call the macro ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION that are of the form that
supports a definition list of the following form:

ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION(FastElements);
ELEMENTS_KIND_CHECK_RUNTIME_FUNCTION(FastDoubleElements);
....

+#define OBJECT_HAS(Name)                                  \
+  RUNTIME_FUNCTION(MaybeObject*, Runtime_Object##Name) {  \
+    CONVERT_CHECKED(JSObject, obj, args[0]);              \
+    return isolate->heap()->ToBoolean(obj->Name());       \
+  }
+
+OBJECT_HAS(HasFastElements)
+OBJECT_HAS(HasFastDoubleElements)
+OBJECT_HAS(HasDictionaryElements)
+OBJECT_HAS(HasExternalPixelElements)
+OBJECT_HAS(HasExternalArrayElements)
+OBJECT_HAS(HasExternalByteElements)
+OBJECT_HAS(HasExternalUnsignedByteElements)
+OBJECT_HAS(HasExternalShortElements)
+OBJECT_HAS(HasExternalUnsignedShortElements)
+OBJECT_HAS(HasExternalIntElements)
+OBJECT_HAS(HasExternalUnsignedIntElements)
+OBJECT_HAS(HasExternalFloatElements)
+OBJECT_HAS(HasExternalDoubleElements)
+
+#undef OBJECT_HAS
+
 // ----------------------------------------------------------------------------
 // Implementation of Runtime
 
 #define F(name, number_of_args, result_size)                             \
   { Runtime::k##name, Runtime::RUNTIME, #name,   \
     FUNCTION_ADDR(Runtime_##name), number_of_args, result_size },
 
 
 #define I(name, number_of_args, result_size)                             \
   { Runtime::kInline##name, Runtime::INLINE,     \
@@ skipping 60 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     isolate->counters()->gc_last_resort_from_js()->Increment();
     isolate->heap()->CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal