Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 7287001: Add a device policy for specifying the release channel. (Closed)

Created:
9 years, 5 months ago by Patrick Dubroy
Modified:
9 years, 5 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add a device policy for specifying the release channel. This is a first step towards a full solution. For now, if the release channel is specified in a policy, it has the same effect as if the user changed the combo box on the About page. Still to-do: store policy value into a LocalState pref, UI changes, and make the setting secure (it's currently stored in /etc/lsb-release). BUG=chromium-os:15382 TEST=Run a local device_management test server and specify the release channel in the device policy. Edit /etc/init/update-engine.conf to start update_engine with the --v=0 option and restart update-engine. Enroll the device and verify in /var/log/update-engine.conf that the track change was noticed by the update engine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91280

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix indent issue. #

Total comments: 10

Patch Set 3 : Address reviewer comments #

Total comments: 1

Patch Set 4 : Rebased #

Patch Set 5 : Change inconsistent wording in policy template. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M chrome/app/policy/policy_templates.json View 1 2 3 4 2 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros_settings_names.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros_settings_names.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/user_cros_settings_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Patrick Dubroy
9 years, 5 months ago (2011-06-29 16:25:05 UTC) #1
gfeher
http://codereview.chromium.org/7287001/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/7287001/diff/1/chrome/app/policy/policy_templates.json#newcode1577 chrome/app/policy/policy_templates.json:1577: 'desc': '''Specifies the release channel that this device should ...
9 years, 5 months ago (2011-06-29 16:28:16 UTC) #2
Patrick Dubroy
http://codereview.chromium.org/7287001/diff/1/chrome/browser/policy/device_policy_cache.cc File chrome/browser/policy/device_policy_cache.cc (right): http://codereview.chromium.org/7287001/diff/1/chrome/browser/policy/device_policy_cache.cc#newcode309 chrome/browser/policy/device_policy_cache.cc:309: kPolicyChromeOsReleaseChannel, Value::CreateStringValue(channel)); On 2011/06/29 16:28:16, gfeher wrote: > Nit: ...
9 years, 5 months ago (2011-06-30 12:24:50 UTC) #3
gfeher
Okay, I am fine with this overall. http://codereview.chromium.org/7287001/diff/6001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/7287001/diff/6001/chrome/app/policy/policy_templates.json#newcode1570 chrome/app/policy/policy_templates.json:1570: 'type': 'string', ...
9 years, 5 months ago (2011-06-30 12:49:28 UTC) #4
pastarmovj
Just one more comment from me. I will LGTM it when you fix Gabor's comments ...
9 years, 5 months ago (2011-06-30 13:12:17 UTC) #5
Patrick Dubroy
http://codereview.chromium.org/7287001/diff/6001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/7287001/diff/6001/chrome/app/policy/policy_templates.json#newcode1570 chrome/app/policy/policy_templates.json:1570: 'type': 'string', On 2011/06/30 12:49:28, gfeher wrote: > Nit: ...
9 years, 5 months ago (2011-06-30 14:28:39 UTC) #6
pastarmovj
LGTM
9 years, 5 months ago (2011-06-30 14:49:17 UTC) #7
gfeher
LGTM with a nit (or question) and pending happy trybots http://codereview.chromium.org/7287001/diff/3002/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/7287001/diff/3002/chrome/app/policy/policy_templates.json#newcode1594 ...
9 years, 5 months ago (2011-06-30 15:09:58 UTC) #8
commit-bot: I haz the power
Change committed as 91280
9 years, 5 months ago (2011-07-01 09:17:22 UTC) #9
fta
> Change committed as 91280 This broke my Ubuntu/Launchpad translations. It seems my grit<->gettext converter ...
9 years, 5 months ago (2011-07-02 12:22:35 UTC) #10
gfeher
I'll take a look at this.
9 years, 5 months ago (2011-07-02 12:29:14 UTC) #11
fta
> "IDS_POLICY_ENUM_<NAME OF THE ITEM>" .. it also means that those 'name' fields should be ...
9 years, 5 months ago (2011-07-02 12:38:53 UTC) #12
gfeher
9 years, 5 months ago (2011-07-02 13:20:30 UTC) #13
I've opened a bug because the issue is not strictly related to this CL:
http://crbug.com/88301

Powered by Google App Engine
This is Rietveld 408576698