Make Windows FindBar stay within window bounds for narrow windows

Make Windows FindBar stay within window bounds for narrow windows.

BUG=None
Test=FindInPageControllerTest.FitWindow. Manual test by opening a narrow window/popup. Open FindBar (ctrl-F). Verify FindBar fits within the window. Resize the width of the window. Verify FindBar width adjusts accordingly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91231

[jennb, 2011-06-30 18:09:08]

Ben, do you have time to review this? If not, point me at someone else.

Thanks,
Jenn

[Finnur, 2011-06-30 22:10:24]

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
File chrome/browser/ui/views/dropdown_bar_host_win.cc (left):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
chrome/browser/ui/views/dropdown_bar_host_win.cc:29: swp_flags |= SWP_NOSIZE;
why is this necessary?

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
File chrome/browser/ui/views/dropdown_bar_host_win.cc (right):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
chrome/browser/ui/views/dropdown_bar_host_win.cc:26: gfx::Rect window_rect =
host_->GetWindowScreenBounds();
This is redundant now...

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/find_ba...
File chrome/browser/ui/views/find_bar_view.cc (right):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_view.cc:266: panel_width = view_width;
When is |view_width| 0?

[jennb, 2011-06-30 22:26:47]

New patch not uploaded yet. Seeing if answers to your questions spawn further
changes first.

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
File chrome/browser/ui/views/dropdown_bar_host_win.cc (left):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
chrome/browser/ui/views/dropdown_bar_host_win.cc:29: swp_flags |= SWP_NOSIZE;
On 2011/06/30 22:10:24, Finnur wrote:
> why is this necessary?

DropdownBarView::PaintOffsetToolbarBackground was getting the same window screen
bounds even though the FindBar width had changed. Removing SWP_NOSIZE fixed
that.

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
File chrome/browser/ui/views/dropdown_bar_host_win.cc (right):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/dropdow...
chrome/browser/ui/views/dropdown_bar_host_win.cc:26: gfx::Rect window_rect =
host_->GetWindowScreenBounds();
On 2011/06/30 22:10:24, Finnur wrote:
> This is redundant now...

Done.

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/find_ba...
File chrome/browser/ui/views/find_bar_view.cc (right):

http://codereview.chromium.org/7285005/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_view.cc:266: panel_width = view_width;
On 2011/06/30 22:10:24, Finnur wrote:
> When is |view_width| 0?

The view's width is zero the first 3 times Layout() is called. After
SetWindowPos takes effect (asynchronously?), the width is set from then on.

[Finnur, 2011-06-30 22:42:49]

OK, LGTM.

[commit-bot: I haz the power, 2011-06-30 23:48:27]

Change committed as 91231