Make Windows FindBar stay within window bounds for narrow windows

chrome/browser/ui/views/dropdown_bar_host_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/dropdown_bar_host.h"
 
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/tab_contents/tab_contents_view.h"
 #include "ui/base/keycodes/keyboard_code_conversion_win.h"
 #include "views/controls/scrollbar/native_scroll_bar.h"
 
 NativeWebKeyboardEvent DropdownBarHost::GetKeyboardEvent(
      const TabContents* contents,
      const views::KeyEvent& key_event) {
   HWND hwnd = contents->GetContentNativeView();
   WORD key = WindowsKeyCodeForKeyboardCode(key_event.key_code());
 
   return NativeWebKeyboardEvent(hwnd, key_event.native_event().message, key, 0);
 }
 
 void DropdownBarHost::SetWidgetPositionNative(const gfx::Rect& new_pos,
                                               bool no_redraw) {
   gfx::Rect window_rect = host_->GetWindowScreenBounds();

[Finnur, 2011/06/30 22:10:24]

This is redundant now...

[jennb, 2011/06/30 22:26:47]

Done.

   DWORD swp_flags = SWP_NOOWNERZORDER;
-  if (!window_rect.IsEmpty())
-    swp_flags |= SWP_NOSIZE;

[Finnur, 2011/06/30 22:10:24]

why is this necessary?

[jennb, 2011/06/30 22:26:47]

DropdownBarView::PaintOffsetToolbarBackground was getting the same window screen
bounds even though the FindBar width had changed. Removing SWP_NOSIZE fixed
that.

   if (no_redraw)
     swp_flags |= SWP_NOREDRAW;
   if (!host_->IsVisible())
     swp_flags |= SWP_SHOWWINDOW;
 
   ::SetWindowPos(host_->GetNativeView(), HWND_TOP, new_pos.x(), new_pos.y(),
                  new_pos.width(), new_pos.height(), swp_flags);
 }