Issue 7284018: posix: remove LaunchAppInNewProcessGroup

Issue 7284018: posix: remove LaunchAppInNewProcessGroup (Closed)

Created:
9 years, 5 months ago by Evan Martin

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

posix: remove LaunchAppInNewProcessGroup Due to refactoring, we can use the common API for this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91612

Patch Set 2 : rebase #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -30 lines)			Patch
M	base/process_util.h	View	1	1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/common/launchd_mac.mm	View		1 chunk	+4 lines, -6 lines	2 comments	Download
M	chrome/test/out_of_proc_test_runner.cc	View		2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/7284018/diff/1004/chrome/common/launchd_mac.mm File chrome/common/launchd_mac.mm (right): http://codereview.chromium.org/7284018/diff/1004/chrome/common/launchd_mac.mm#newcode123 chrome/common/launchd_mac.mm:123: argv.push_back("/bin/bash"); This function is absolute crap anyway. I ...

9 years, 5 months ago (2011-06-29 21:58:37 UTC) #1

Evan Martin

http://codereview.chromium.org/7284018/diff/1004/chrome/common/launchd_mac.mm File chrome/common/launchd_mac.mm (right): http://codereview.chromium.org/7284018/diff/1004/chrome/common/launchd_mac.mm#newcode123 chrome/common/launchd_mac.mm:123: argv.push_back("/bin/bash"); On 2011/06/29 21:58:37, Mark Mentovai wrote: > This ...

9 years, 5 months ago (2011-06-29 22:02:55 UTC) #2

Mark Mentovai

9 years, 5 months ago (2011-06-29 22:13:22 UTC) #3

evan@chromium.org wrote:
> On 2011/06/29 21:58:37, Mark Mentovai wrote:
>>
>> This function is absolute crap anyway. I just wrote something that can
replace
>> it.
>
> Ah, feel free to land that before I land this, since it's one patch
> removed from landing (it depends on my other change).  This change is
> simple so the conflicts will be small.

You should land this one first. I just have a utility that will let us
interface with launchd without having to execute launchctl. Making
this function use it is another thing.

Expand Messages | Collapse Messages