posix: remove LaunchAppInNewProcessGroup

chrome/common/launchd_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/launchd_mac.h"
 
 #import <Foundation/Foundation.h>
 #include <launch.h>
 
 #include "base/mac/mac_util.h"
@@ skipping 102 matching lines @@
   ns_path = SanitizeShellArgument(ns_path);
   const char* file_path = [ns_path fileSystemRepresentation];
 
   NSString* ns_session_type =
       SanitizeShellArgument(base::mac::CFToNSCast(cf_session_type));
   if (!file_path || !ns_session_type) {
     return false;
   }
 
   std::vector<std::string> argv;
   argv.push_back("/bin/bash");

[Mark Mentovai, 2011/06/29 21:58:37]

This function is absolute crap anyway. I just wrote something that can replace
it.

[Evan Martin, 2011/06/29 22:02:55]

Ah, feel free to land that before I land this, since it's one patch removed from
landing (it depends on my other change).  This change is simple so the conflicts
will be small.

   argv.push_back("--noprofile");
   argv.push_back("-c");
   std::string command = base::StringPrintf(
       "/bin/launchctl unload -S %s %s;"
       "/bin/launchctl load -S %s %s;",
       [ns_session_type UTF8String], file_path,
       [ns_session_type UTF8String], file_path);
   argv.push_back(command);
-  base::ProcessHandle handle;
-  return base::LaunchAppInNewProcessGroup(argv,
-                                          base::environment_vector(),
-                                          base::file_handle_mapping_vector(),
-                                          NO,
-                                          &handle);
+
+  base::LaunchOptions options;
+  options.new_process_group = true;
+  return base::LaunchApp(argv, options);
 }
 
 CFMutableDictionaryRef Launchd::CreatePlistFromFile(Domain domain,
                                                     Type type,
                                                     CFStringRef name) {
   base::mac::ScopedNSAutoreleasePool pool;
   NSURL* ns_url = GetPlistURL(domain, type, name);
   NSMutableDictionary* plist =
       [[NSMutableDictionary alloc] initWithContentsOfURL:ns_url];
   return base::mac::NSToCFCast(plist);
@@ skipping 14 matching lines @@
   NSError* err = nil;
   if (![[NSFileManager defaultManager] removeItemAtPath:[ns_url path]
                                                   error:&err]) {
     if ([err code] != NSFileNoSuchFileError) {
       LOG(ERROR) << "DeletePlist: " << base::mac::NSToCFCast(err);
     }
     return false;
   }
   return true;
 }