src/ia32/ic-ia32.cc - Issue 7282029: Fix problem with arguments object ICs not checking for dictionary mode elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 7282029: Fix problem with arguments object ICs not checking for dictionary mode elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index 0f5820254de7d952673e9fc18388e7a54b4ff1ca..be5910a1243b7671f069f3fafc66262e9b47f144 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -528,6 +528,8 @@ static Operand GenerateUnmappedArgumentsLookup(MacroAssembler* masm,

const int kBackingStoreOffset = FixedArray::kHeaderSize + kPointerSize;

__ mov(backing_store, FieldOperand(parameter_map, kBackingStoreOffset));

+ Handle<Map> fixed_array_map(masm->isolate()->heap()->fixed_array_map());

+ __ CheckMap(backing_store, fixed_array_map, slow_case, DONT_DO_SMI_CHECK);

__ mov(scratch, FieldOperand(backing_store, FixedArray::kLengthOffset));

__ cmp(key, Operand(scratch));

__ j(greater_equal, slow_case);

« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/runtime.cc » ('j') | no next file with comments »