Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 7282029: Fix problem with arguments object ICs not checking for dictionary mode elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 static Operand GenerateUnmappedArgumentsLookup(MacroAssembler* masm, 521 static Operand GenerateUnmappedArgumentsLookup(MacroAssembler* masm,
522 Register key, 522 Register key,
523 Register parameter_map, 523 Register parameter_map,
524 Register scratch, 524 Register scratch,
525 Label* slow_case) { 525 Label* slow_case) {
526 // Element is in arguments backing store, which is referenced by the 526 // Element is in arguments backing store, which is referenced by the
527 // second element of the parameter_map. 527 // second element of the parameter_map.
528 const int kBackingStoreOffset = FixedArray::kHeaderSize + kPointerSize; 528 const int kBackingStoreOffset = FixedArray::kHeaderSize + kPointerSize;
529 Register backing_store = parameter_map; 529 Register backing_store = parameter_map;
530 __ mov(backing_store, FieldOperand(parameter_map, kBackingStoreOffset)); 530 __ mov(backing_store, FieldOperand(parameter_map, kBackingStoreOffset));
531 Handle<Map> fixed_array_map(masm->isolate()->heap()->fixed_array_map());
532 __ CheckMap(backing_store, fixed_array_map, slow_case, DONT_DO_SMI_CHECK);
531 __ mov(scratch, FieldOperand(backing_store, FixedArray::kLengthOffset)); 533 __ mov(scratch, FieldOperand(backing_store, FixedArray::kLengthOffset));
532 __ cmp(key, Operand(scratch)); 534 __ cmp(key, Operand(scratch));
533 __ j(greater_equal, slow_case); 535 __ j(greater_equal, slow_case);
534 return FieldOperand(backing_store, 536 return FieldOperand(backing_store,
535 key, 537 key,
536 times_half_pointer_size, 538 times_half_pointer_size,
537 FixedArray::kHeaderSize); 539 FixedArray::kHeaderSize);
538 } 540 }
539 541
540 542
(...skipping 1194 matching lines...) Expand 10 before | Expand all | Expand 10 after
1735 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1737 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1736 ? not_zero 1738 ? not_zero
1737 : zero; 1739 : zero;
1738 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1740 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1739 } 1741 }
1740 1742
1741 1743
1742 } } // namespace v8::internal 1744 } } // namespace v8::internal
1743 1745
1744 #endif // V8_TARGET_ARCH_IA32 1746 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698