Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 7278008: Fix obvious leak in chrome_web_ui_data_source_unittest.cc, and revert associated suppresions. (Closed)

Created:
9 years, 5 months ago by Tom Sepez
Modified:
9 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix obvious leak in chrome_web_ui_data_source_unittest.cc, and revert associated suppresions. BUG=88094 TEST=heapchecks clean about ChromeWebUIDataSource Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -43 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Sepez
9 years, 5 months ago (2011-06-30 22:34:58 UTC) #1
Tom Sepez
On 2011/06/30 22:34:58, Tom Sepez wrote: Is there a good way to test that this ...
9 years, 5 months ago (2011-06-30 22:35:26 UTC) #2
Tom Sepez
http://build.chromium.org/p/tryserver.chromium/builders/linux_valgrind/builds/1250 In particular, this try job seems useless. Does it need a --testfilter on the ...
9 years, 5 months ago (2011-06-30 23:08:39 UTC) #3
Tom Sepez
Nevermind. Test names are different between valgrind and normal. linux (not valgrind) try job: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/35000
9 years, 5 months ago (2011-06-30 23:11:23 UTC) #4
oshima
LGTM thanks! On Thu, Jun 30, 2011 at 4:11 PM, <tsepez@chromium.org> wrote: > Nevermind. Test ...
9 years, 5 months ago (2011-06-30 23:15:46 UTC) #5
Tom Sepez
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/35557 http://build.chromium.org/p/tryserver.chromium/builders/win/builds/40291 green unit-test only runs on other platforms
9 years, 5 months ago (2011-06-30 23:28:44 UTC) #6
Tom Sepez
9 years, 5 months ago (2011-07-01 00:14:32 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698