Fix obvious leak in chrome_web_ui_data_source_unittest.cc, and revert associated suppresions.

chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted_memory.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "grit/common_resources.h"
 #include "grit/generated_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // A mock data source (so we can override SendResponse to get at its data).
 class MockChromeWebUIDataSource : public ChromeWebUIDataSource {
  public:
   MockChromeWebUIDataSource()
       : ChromeWebUIDataSource("host"),
         result_request_id_(-1),
         result_data_(NULL) {
   }
 
   virtual ~MockChromeWebUIDataSource() {
-    result_data_ = NULL;
   }
 
   // Subvert protected methods.
   virtual void StartDataRequest(
       const std::string& path, bool is_incognito, int request_id) OVERRIDE {
     ChromeWebUIDataSource::StartDataRequest(path, is_incognito, request_id);
   }
 
   virtual std::string GetMimeType(const std::string& path) const OVERRIDE {
     return ChromeWebUIDataSource::GetMimeType(path);
   }
 
   // Store response for later comparisons.
   virtual void SendResponse(int request_id, RefCountedMemory* data) {
     result_request_id_ = request_id;
     result_data_ = data;
   }
 
   int result_request_id_;
   scoped_refptr<RefCountedMemory> result_data_;
 };
 
 class ChromeWebUIDataSourceTest : public testing::Test {
  public:
   ChromeWebUIDataSourceTest() {}
-  MockChromeWebUIDataSource* source() { return source_; }
+  virtual ~ChromeWebUIDataSourceTest() {}
+  MockChromeWebUIDataSource* source() { return source_.get(); }
 
  private:
   virtual void SetUp() {
-    source_ = new MockChromeWebUIDataSource();
+    source_ = make_scoped_refptr(new MockChromeWebUIDataSource());
   }
 
   virtual void TearDown() {
   }
 
-  MockChromeWebUIDataSource* source_;
+  scoped_refptr<MockChromeWebUIDataSource> source_;
 };
 
 TEST_F(ChromeWebUIDataSourceTest, EmptyStrings) {
   source()->set_json_path("strings.js");
   source()->StartDataRequest("strings.js" , false, 1);
   EXPECT_EQ(source()->result_request_id_, 1);
   std::string result(reinterpret_cast<const char*>(
       source()->result_data_->front()), source()->result_data_->size());
   EXPECT_NE(result.find("var templateData = {"), std::string::npos);
   EXPECT_NE(result.find("};"), std::string::npos);
@@ skipping 49 matching lines @@
   const char* js = "application/javascript";
   EXPECT_EQ(source()->GetMimeType(""), html);
   EXPECT_EQ(source()->GetMimeType("foo"), html);
   EXPECT_EQ(source()->GetMimeType("foo.html"), html);
   EXPECT_EQ(source()->GetMimeType(".js"), js);
   EXPECT_EQ(source()->GetMimeType("foo.js"), js);
   EXPECT_EQ(source()->GetMimeType("js"), html);
   EXPECT_EQ(source()->GetMimeType("foojs"), html);
   EXPECT_EQ(source()->GetMimeType("foo.jsp"), html);
 }