Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 7277083: [libphonenumber] snprintf isn't generally in the std:: namespace (Closed)

Created:
9 years, 5 months ago by Chris Masone
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[libphonenumber] snprintf isn't generally in the std:: namespace Due to some relatively common gnu-isms, one can often use snprintf by calling std::snprintf. It's not necessarily proper to do so, though, and the ARM toolchain used on Chromium OS does not support it. BUG=None TEST=unit tests R=georgey Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91437

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M third_party/libphonenumber/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libphonenumber/cpp/src/default_logger.h View 1 2 chunks +3 lines, -1 line 0 comments Download
A third_party/libphonenumber/patches/version277a.patch View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Chris Masone
building locally and running tryjobs now...PTAL
9 years, 5 months ago (2011-07-02 23:22:28 UTC) #1
Ryan Sleevi
http://codereview.chromium.org/7277083/diff/1/third_party/libphonenumber/cpp/src/default_logger.h File third_party/libphonenumber/cpp/src/default_logger.h (right): http://codereview.chromium.org/7277083/diff/1/third_party/libphonenumber/cpp/src/default_logger.h#newcode19 third_party/libphonenumber/cpp/src/default_logger.h:19: I believe it may be necessary to add #include ...
9 years, 5 months ago (2011-07-02 23:25:42 UTC) #2
Chris Masone
done
9 years, 5 months ago (2011-07-02 23:33:18 UTC) #3
Ryan Sleevi
LGTM
9 years, 5 months ago (2011-07-02 23:34:17 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-03 01:21:00 UTC) #5
No LGTM from valid reviewers yet.

Powered by Google App Engine
This is Rietveld 408576698