[libphonenumber] snprintf isn't generally in the std:: namespace

third_party/libphonenumber/cpp/src/default_logger.h

 // Copyright (C) 2011 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 // http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 // Author: Philippe Liard
 
 #ifndef I18N_PHONENUMBERS_DEFAULT_LOGGER_H_
 #define I18N_PHONENUMBERS_DEFAULT_LOGGER_H_
 

[Ryan Sleevi, 2011/07/02 23:25:42]

I believe it may be necessary to add

#include <stdio.h>

In order to pull in snprintf. On x86+gcc, this is handled by logger.h including
<cstdio> (which is what brings in std::snprintf). It may be that the ARM
toolchain transitively has these headers included somewhere by <string>, but to
be safe, probably easier to add the explicit include.

 #include <string>
 
 #include "logger.h"
 
 using std::string;
 
 // Make the logging functions private (not declared in logger.h) as the client
 // should not have any reason to use them.
 namespace {
 
@@ skipping 11 matching lines @@
   }
 };
 
 template <>
 struct ConvertToString<int> {
   static inline string DoWork(const int& n) {
     char buffer[16];
 #if defined(OS_WIN)
     _itoa_s(n, buffer, sizeof(buffer), 10);
 #else
-    std::snprintf(buffer, sizeof(buffer), "%d", n);
+    snprintf(buffer, sizeof(buffer), "%d", n);
 #endif
     return string(buffer);
   }
 };
 
 class LoggerHandler {
  public:
   LoggerHandler(Logger* impl) : impl_(impl) {}
 
   ~LoggerHandler() {
@@ skipping 26 matching lines @@
   virtual ~StdoutLogger() {}
 
   virtual void WriteLevel();
   virtual void WriteMessage(const string& msg);
 };
 
 }  // namespace phonenumbers
 }  // namespace i18n
 
 #endif  // I18N_PHONENUMBERS_DEFAULT_LOGGER_H_