While initializing the pepper plugin registry in the renderer we load each plugin and attempt to ...

While initializing the pepper plugin registry in the renderer we load each plugin and attempt to initialize
it. If initialization fails for a plugin the code in PluginModule unloads the plugin but still attempts
to invoke the shutdown function on an unloaded plugin module.

Proposed fix is to initialize the entry points member with the plugin entry points only when initialization
succeeds.

BUG=none
TEST=The renderer should not crash if initializing a pepper plugin fails.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91756

[brettw, 2011-07-06 18:27:54]

http://codereview.chromium.org/7277077/diff/3/webkit/plugins/ppapi/plugin_mod...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7277077/diff/3/webkit/plugins/ppapi/plugin_mod...
webkit/plugins/ppapi/plugin_module.cc:461: memset(&entry_points_, 0,
sizeof(entry_points_));
Can we do this in the constructor instead?

[ananta, 2011-07-06 18:41:53]

http://codereview.chromium.org/7277077/diff/3/webkit/plugins/ppapi/plugin_mod...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7277077/diff/3/webkit/plugins/ppapi/plugin_mod...
webkit/plugins/ppapi/plugin_module.cc:461: memset(&entry_points_, 0,
sizeof(entry_points_));
On 2011/07/06 18:27:54, brettw wrote:
> Can we do this in the constructor instead?

I moved the memset to the constructor. However the problem is not that this
structure is uninitialized. Basically we load the entry points and then try to
initialize the plugin. If the initialize fails we try to uninitialize it which
crashes.

Changed the code around to only initialize the entry points member if the plugin
initialization succeeds.

[brettw, 2011-07-06 20:06:02]

LGTM