While initializing the pepper plugin registry in the renderer we load each plugin and attempt to ...

webkit/plugins/ppapi/plugin_module.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/plugin_module.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
@@ skipping 440 matching lines @@
   return InitializeModule();
 }
 
 bool PluginModule::InitAsLibrary(const FilePath& path) {
   base::NativeLibrary library = base::LoadNativeLibrary(path, NULL);
   if (!library)
     return false;
 
   if (!LoadEntryPointsFromLibrary(library, &entry_points_) ||
       !InitializeModule()) {
+    memset(&entry_points_, 0, sizeof(entry_points_));

[brettw, 2011/07/06 18:27:54]

Can we do this in the constructor instead?

[ananta, 2011/07/06 18:41:53]

I moved the memset to the constructor. However the problem is not that this
structure is uninitialized. Basically we load the entry points and then try to
initialize the plugin. If the initialize fails we try to uninitialize it which
crashes.

Changed the code around to only initialize the entry points member if the plugin
initialization succeeds.

     base::UnloadNativeLibrary(library);
     return false;
   }
 
   library_ = library;
   return true;
 }
 
 void PluginModule::InitAsProxied(
     PluginDelegate::OutOfProcessProxy* out_of_process_proxy) {
@@ skipping 106 matching lines @@
   int retval = entry_points_.initialize_module(pp_module(), &GetInterface);
   if (retval != 0) {
     LOG(WARNING) << "PPP_InitializeModule returned failure " << retval;
     return false;
   }
   return true;
 }
 
 }  // namespace ppapi
 }  // namespace webkit