Issue 7277031: Ensure 16-byte stack alignment on Solaris.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7277031: Ensure 16-byte stack alignment on Solaris. (Closed)

Created:
9 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 5 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Ensure 16-byte stack alignment on Solaris. GCC generates instructions such as movdqa that requires 16-byte alignment. R=ricow@chromium.org BUG=v8:1505 TEST= Committed: http://code.google.com/p/v8/source/detail?r=8432

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	ChangeLog	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/platform-solaris.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 5 months ago (2011-06-28 07:06:17 UTC) #2

LGTM

http://codereview.chromium.org/7277031/diff/1/src/platform-solaris.cc
File src/platform-solaris.cc (right):

http://codereview.chromium.org/7277031/diff/1/src/platform-solaris.cc#newcode108
src/platform-solaris.cc:108: // GCC generate code that requires 16 byte
alignment such as movdqa.
GCC generates

Expand Messages | Collapse Messages