Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: src/platform-solaris.cc

Issue 7277031: Ensure 16-byte stack alignment on Solaris. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ChangeLog ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 srandom(static_cast<unsigned int>(seed)); 98 srandom(static_cast<unsigned int>(seed));
99 } 99 }
100 100
101 101
102 uint64_t OS::CpuFeaturesImpliedByPlatform() { 102 uint64_t OS::CpuFeaturesImpliedByPlatform() {
103 return 0; // Solaris runs on a lot of things. 103 return 0; // Solaris runs on a lot of things.
104 } 104 }
105 105
106 106
107 int OS::ActivationFrameAlignment() { 107 int OS::ActivationFrameAlignment() {
108 return STACK_ALIGN; 108 // GCC generates code that requires 16 byte alignment such as movdqa.
109 return Max(STACK_ALIGN, 16);
109 } 110 }
110 111
111 112
112 void OS::ReleaseStore(volatile AtomicWord* ptr, AtomicWord value) { 113 void OS::ReleaseStore(volatile AtomicWord* ptr, AtomicWord value) {
113 __asm__ __volatile__("" : : : "memory"); 114 __asm__ __volatile__("" : : : "memory");
114 *ptr = value; 115 *ptr = value;
115 } 116 }
116 117
117 118
118 const char* OS::LocalTimezone(double time) { 119 const char* OS::LocalTimezone(double time) {
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 data_->signal_handler_installed_ = false; 752 data_->signal_handler_installed_ = false;
752 } 753 }
753 754
754 // This sampler is no longer the active sampler. 755 // This sampler is no longer the active sampler.
755 active_sampler_ = NULL; 756 active_sampler_ = NULL;
756 } 757 }
757 758
758 #endif // ENABLE_LOGGING_AND_PROFILING 759 #endif // ENABLE_LOGGING_AND_PROFILING
759 760
760 } } // namespace v8::internal 761 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « ChangeLog ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698