Issue 7274033: Fixes race condition that could lead to premature shutdown. When

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7274033: Fixes race condition that could lead to premature shutdown. When (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes race condition that could lead to premature shutdown. When session restore has been initiated we don't want to exit. Previously this was possible if session restore was initiated and the last window closed (this happens on chromeos). To avoid this when session restore starts it AddRefs, and then Releases when done. BUG=83861 TEST=covered by test R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91003

Patch Set 1 #

Patch Set 2 : Remove FLAKY_ from test #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/sessions/session_restore.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/session_restore.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages