Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc

Issue 7274033: Fixes race condition that could lead to premature shutdown. When (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove FLAKY_ from test Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sessions/session_restore.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
diff --git a/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc b/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
index 6d39923f1d30edbe705075cc8ec3fbe6aa296c4e..d09c4bd3c0699287581f0b074f2c4ea1fed66a09 100644
--- a/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
+++ b/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc
@@ -247,11 +247,7 @@ IN_PROC_BROWSER_TEST_F(TabCloseableStateWatcherTest, SecondIncognitoBrowser) {
// Tests closing an incognito browser - the incognito browser should close,
// and a new normal browser opened with a NewTabPage (which is not closeable).
-// Test is flaky:
-// EXPECT_EQ(1u, BrowserList::size()) in the "Close incognito browser." block
-// currently fails in ~13% of all runs. See http://crbug.com/83861
-IN_PROC_BROWSER_TEST_F(TabCloseableStateWatcherTest,
- FLAKY_CloseIncognitoBrowser) {
+IN_PROC_BROWSER_TEST_F(TabCloseableStateWatcherTest, CloseIncognitoBrowser) {
NavigateToURL(ntp_url_);
// Open an incognito browser.
« no previous file with comments | « no previous file | chrome/browser/sessions/session_restore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698