Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 7274025: Slightly improved register assignment for %_IsObject on IA32 and ARM. (Closed)

Created:
9 years, 5 months ago by fschneider
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Slightly improved register assignment for %_IsObject on IA32 and ARM. The new approach uses one temp register instead of two on IA32. The ARM instructions are modified so the input can be UseAtStart again. Committed: http://code.google.com/p/v8/source/detail?r=8451

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -37 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 5 months ago (2011-06-28 14:01:32 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-06-28 14:09:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698