Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 7274020: Better placement of argument pushing for a few hydrogen call instructions. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 5 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Better placement of argument pushing for a few hydrogen call instructions. Where it's simple to do so (keyed calls, calls to unknown global variables, calls to local variables and non-property/non-variable expressions), end the live range of argument subexpressions immediately after the last use of the expression rather than at the call. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8445

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/hydrogen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +29 lines, -25 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
9 years, 5 months ago (2011-06-28 10:47:20 UTC) #1
Kevin Millikin (Chromium)
http://codereview.chromium.org/7274020/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7274020/diff/1/src/hydrogen.cc#newcode4848 src/hydrogen.cc:4848: CHECK_ALIVE(constructor = VisitArgument(expr->expression())); I realize this is kind of ...
9 years, 5 months ago (2011-06-28 10:51:29 UTC) #2
fschneider
9 years, 5 months ago (2011-06-28 11:14:16 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698