Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Side by Side Diff: src/hydrogen.h

Issue 7274020: Better placement of argument pushing for a few hydrogen call instructions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 798 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 // test contexts.) 809 // test contexts.)
810 void VisitForValue(Expression* expr, 810 void VisitForValue(Expression* expr,
811 ArgumentsAllowedFlag flag = ARGUMENTS_NOT_ALLOWED); 811 ArgumentsAllowedFlag flag = ARGUMENTS_NOT_ALLOWED);
812 void VisitForTypeOf(Expression* expr); 812 void VisitForTypeOf(Expression* expr);
813 void VisitForEffect(Expression* expr); 813 void VisitForEffect(Expression* expr);
814 void VisitForControl(Expression* expr, 814 void VisitForControl(Expression* expr,
815 HBasicBlock* true_block, 815 HBasicBlock* true_block,
816 HBasicBlock* false_block); 816 HBasicBlock* false_block);
817 817
818 // Visit an argument subexpression and emit a push to the outgoing 818 // Visit an argument subexpression and emit a push to the outgoing
819 // arguments. 819 // arguments. Returns the hydrogen value that was pushed.
820 void VisitArgument(Expression* expr); 820 HValue* VisitArgument(Expression* expr);
821
821 void VisitArgumentList(ZoneList<Expression*>* arguments); 822 void VisitArgumentList(ZoneList<Expression*>* arguments);
822 823
823 // Visit a list of expressions from left to right, each in a value context. 824 // Visit a list of expressions from left to right, each in a value context.
824 void VisitExpressions(ZoneList<Expression*>* exprs); 825 void VisitExpressions(ZoneList<Expression*>* exprs);
825 826
826 void AddPhi(HPhi* phi); 827 void AddPhi(HPhi* phi);
827 828
828 void PushAndAdd(HInstruction* instr); 829 void PushAndAdd(HInstruction* instr);
829 830
830 // Remove the arguments from the bailout environment and emit instructions 831 // Remove the arguments from the bailout environment and emit instructions
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
1209 const char* filename_; 1210 const char* filename_;
1210 HeapStringAllocator string_allocator_; 1211 HeapStringAllocator string_allocator_;
1211 StringStream trace_; 1212 StringStream trace_;
1212 int indent_; 1213 int indent_;
1213 }; 1214 };
1214 1215
1215 1216
1216 } } // namespace v8::internal 1217 } } // namespace v8::internal
1217 1218
1218 #endif // V8_HYDROGEN_H_ 1219 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698