Get Chrome About dialog 'official build' label to display properly.

Fix Chrome About dialog unicode 'official build' label to display properly.

We recently added a UTF8 encoded 'official build' localized string to the About dialog, but elsewhere in the file that string is treated as containing ASCII. This causes garbage to be displayed in ie. Russian locale.

This affects Chromium builds only, since this is not done for Google Chrome builds.

BUG=87370
TEST=Open Chromium in Russian locale. No garbage should been seen in the dialog (see screenshot in bug).
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90776

[Evan Martin, 2011-06-27 17:40:23]

Shouldn't the offical build string be UTF-16 to begin with, if it contains
Unicode?  The reason we use string16 is so we don't need to be as careful about
ASCII vs UTF-16.

[Finnur, 2011-06-28 10:24:30]

Fair enough. Made that change plus two others:

1) Moved an include to the .h file to appease cpplint.
2) Stopped hard-coding the width of the textbox (containing the string that
previously displayed garbage) to avoid truncation of its content. It now
(invisibly) stretches all the way to the background bitmap (the logo to it's
right).

Please take another look.

[Evan Martin, 2011-06-28 15:53:16]

LGTM

http://codereview.chromium.org/7274001/diff/5003/chrome/browser/ui/views/abou...
File chrome/browser/ui/views/about_chrome_view.h (right):

http://codereview.chromium.org/7274001/diff/5003/chrome/browser/ui/views/abou...
chrome/browser/ui/views/about_chrome_view.h:141: // Additional information about
the version (channel and build number).
Can you note here that a translation of "Official Build" might be included in
the build number?  I think not knowing this is why I (or someone else) made this
a string.

[Evan Martin, 2011-06-28 15:53:17]

LGTM

[Finnur, 2011-06-28 15:57:06]

On 2011/06/28 15:53:16, Evan Martin wrote:
> LGTM
> 
>
http://codereview.chromium.org/7274001/diff/5003/chrome/browser/ui/views/abou...
> File chrome/browser/ui/views/about_chrome_view.h (right):
> 
>
http://codereview.chromium.org/7274001/diff/5003/chrome/browser/ui/views/abou...
> chrome/browser/ui/views/about_chrome_view.h:141: // Additional information
about
> the version (channel and build number).
> Can you note here that a translation of "Official Build" might be included in
> the build number?  I think not knowing this is why I (or someone else) made
this
> a string.

Sure!