Add support for sql_unittests to chrome_tests.py.

Add support for sql_unittests to chrome_tests.py.

BUG=72317
TEST=chrome_tests.sh -t sql

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91956

[Timur Iskhodzhanov, 2011-06-30 04:21:13]

http://codereview.chromium.org/7273087/diff/1/tools/heapcheck/chrome_tests.py
File tools/heapcheck/chrome_tests.py (right):

http://codereview.chromium.org/7273087/diff/1/tools/heapcheck/chrome_tests.py...
tools/heapcheck/chrome_tests.py:99: "sql": self.TestSql,             
"sql_unittests": self.TestSql,
AFAIU you have both sql_unittests and app_unittests
- why not have BOTH "sql" and "app" options pointing at self.TestSql until the
master restart?
Or you can temporarily leave app_unittests/TestApp until the master is restarted

[Marc-Antoine Ruel (Google), 2011-06-30 04:58:29]

I agree with Timur, it will be much easier to manage to do this in 2 phases.

lgtm with adding the sql tests and not removing the app one yet.

[Robert Sesek, 2011-06-30 15:32:20]

I don't know why I didn't do that initially... good call. PTAL.

[Timur Iskhodzhanov, 2011-06-30 15:36:52]

Please also rename
tools/valgrind/gtest_exclude/app_unittests.gtest-tsan.txt
to
tools/valgrind/gtest_exclude/sql_unittests.gtest-tsan.txt

[Robert Sesek, 2011-06-30 15:56:33]

On 2011/06/30 15:36:52, Timur Iskhodzhanov wrote:
> Please also rename
> tools/valgrind/gtest_exclude/app_unittests.gtest-tsan.txt
> to
> tools/valgrind/gtest_exclude/sql_unittests.gtest-tsan.txt

This actually should be for gfx_unittests (or ui_unittests, which I still
haven't renamed...). Done.

[Timur Iskhodzhanov, 2011-06-30 16:48:52]

LGTM, thanks

[Robert Sesek, 2011-07-06 18:54:24]

I had to revert the removal of app_unittests because the Valgrind builders only
build a subset of targets, so if app goes away, they fail until the buildbot
master is restarted.

[M-A Ruel, 2011-07-06 18:55:04]

On 2011/07/06 18:54:24, rsesek wrote:
> I had to revert the removal of app_unittests because the Valgrind builders
only
> build a subset of targets, so if app goes away, they fail until the buildbot
> master is restarted.

Why not make the valgrind builders build it?

[Robert Sesek, 2011-07-06 18:57:43]

On 2011/07/06 18:55:04, Marc-Antoine Ruel wrote:
> On 2011/07/06 18:54:24, rsesek wrote:
> > I had to revert the removal of app_unittests because the Valgrind builders
> only
> > build a subset of targets, so if app goes away, they fail until the buildbot
> > master is restarted.
> 
> Why not make the valgrind builders build it?

I have in the other buildbot master CL; it's just that I want to land this and
not have a hard dependency between two CLs. I can remove app once the master
gets restarted.