Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 7273084: Change the meaning of "Widget::GetTopLevelWidget()" to mean the logical top level Window in the v... (Closed)

Created:
9 years, 5 months ago by Ben Goodger (Google)
Modified:
9 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa
Visibility:
Public.

Description

Change the meaning of "Widget::GetTopLevelWidget()" to mean the logical top level Window in the views desktop world. Adds the beginning of a set of tests for this behavior. Also fixes the leaks associated with destruction of NativeWidgetViews, and adds a moderately comprehensive set of tests for Widget ownership. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91706

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -9 lines) Patch
M views/views.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/widget/native_widget_gtk.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M views/widget/native_widget_private.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M views/widget/native_widget_view.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M views/widget/native_widget_view.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M views/widget/native_widget_views.h View 1 2 4 chunks +14 lines, -1 line 0 comments Download
M views/widget/native_widget_views.cc View 1 2 5 chunks +28 lines, -3 lines 0 comments Download
M views/widget/native_widget_win.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/widget/native_widget_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M views/widget/widget.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A views/widget/widget_unittest.cc View 1 2 1 chunk +362 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 5 months ago (2011-07-06 22:34:44 UTC) #1
sky
9 years, 5 months ago (2011-07-06 22:47:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698